fix(admin): cast BK_INSTRUCTIONS_ALLOWED_EXTENSIONS as a list not a string (see #149)

CHANGELOG.md

@@ -4,9 +4,8 @@
 
 ### Bug Fixes
 
-- **Fixed purchase date, price, and notes not being saved when adding an individual minifigure** (Issue #151, branch `bugfix/issue-151`): Filling in purchase date, price, or notes before clicking Add had no effect, only purchase location was saved
-  - `BrickMinifigureSocket` was missing references to `#add-purchase-date`, `#add-purchase-price`, and `#add-description`, so those fields were never read or included in the socket emit
-  - The backend already supported all three fields. This was just a frontend error
+- **Fixed `BK_INSTRUCTIONS_ALLOWED_EXTENSIONS` being treated as a string instead of a list** (Issue #149b, branch `bugfix/issue-149b`): When this setting was saved via the admin panel, it was stored and cast as a plain string rather than a list, causing it to be iterated character by character (e.g. `['.', 'p', 'd', 'f']` instead of `['.pdf']`)
+  - Added `allowed_extensions` to the list-type keyword detection in `_cast_value()`, matching the existing pattern used for `badge_order` settings
 - **Fixed deleting a wish with an owner assigned** (Issue #152): Resolved foreign key constraint error when removing a set from the wishlist that had an owner assigned
   - Wish owners are now deleted before the wish itself, respecting the FK constraint
 

bricktracker/config_manager.py

@@ -192,7 +192,7 @@ class ConfigManager:
     def _cast_value(self, var_name: str, value: Any) -> Any:
         """Cast value to appropriate type based on variable name"""
         # List variables (admin sections, badge order) - Check this FIRST before boolean check
-        if any(keyword in var_name.lower() for keyword in ['sections', 'badge_order']):
+        if any(keyword in var_name.lower() for keyword in ['sections', 'badge_order', 'allowed_extensions']):
             if isinstance(value, str):
                 return [section.strip() for section in value.split(',') if section.strip()]
             elif isinstance(value, list):

static/scripts/socket/minifigure.js

@@ -13,12 +13,9 @@ class BrickMinifigureSocket extends BrickSocket {
         this.html_input = document.getElementById(`${id}-set`);
         this.html_no_confim = document.getElementById(`${id}-no-confirm`);
         this.html_owners = document.getElementById(`${id}-owners`);
-        this.html_purchase_date = document.getElementById(`${id}-purchase-date`);
-        this.html_purchase_price = document.getElementById(`${id}-purchase-price`);
         this.html_purchase_location = document.getElementById(`${id}-purchase-location`);
         this.html_storage = document.getElementById(`${id}-storage`);
         this.html_tags = document.getElementById(`${id}-tags`);
-        this.html_description = document.getElementById(`${id}-description`);
 
         // Card elements
         this.html_card = document.getElementById(`${id}-card`);
@@ -101,28 +98,12 @@ class BrickMinifigureSocket extends BrickSocket {
                 });
             }
 
-            // Grab the purchase info
-            let purchase_date = null;
-            if (this.html_purchase_date) {
-                purchase_date = this.html_purchase_date.value || null;
-            }
-
-            let purchase_price = null;
-            if (this.html_purchase_price) {
-                purchase_price = this.html_purchase_price.value || null;
-            }
-
+            // Grab the purchase location
             let purchase_location = null;
             if (this.html_purchase_location) {
                 purchase_location = this.html_purchase_location.value;
             }
 
-            // Grab the description (notes)
-            let description = '';
-            if (this.html_description) {
-                description = this.html_description.value || '';
-            }
-
             // Grab the storage
             let storage = null;
             if (this.html_storage) {
@@ -148,12 +129,9 @@ class BrickMinifigureSocket extends BrickSocket {
             this.socket.emit(this.messages.IMPORT_MINIFIGURE, {
                 figure: (figure !== undefined) ? figure : this.html_input.value,
                 owners: owners,
-                purchase_date: purchase_date,
-                purchase_price: purchase_price,
                 purchase_location: purchase_location,
                 storage: storage,
                 tags: tags,
-                description: description,
                 quantity: 1
             });
         } else {
@@ -257,22 +235,10 @@ class BrickMinifigureSocket extends BrickSocket {
             this.html_owners.querySelectorAll('input').forEach(input => input.disabled = !enabled);
         }
 
-        if (this.html_purchase_date) {
-            this.html_purchase_date.disabled = !enabled;
-        }
-
-        if (this.html_purchase_price) {
-            this.html_purchase_price.disabled = !enabled;
-        }
-
         if (this.html_purchase_location) {
             this.html_purchase_location.disabled = !enabled;
         }
 
-        if (this.html_description) {
-            this.html_description.disabled = !enabled;
-        }
-
         if (this.html_storage) {
             this.html_storage.disabled = !enabled;
         }