"Reset to defaults" for configuration clears out all settings instead of applying defaults. #149
Assignees
FrederikBaerentsen
Clear assignees
FrederikBaerentsen
No Assignees
Notifications
Due Date
No due date set.
Dependencies
No dependencies set.
Reference: FrederikBaerentsen/BrickTracker#149
Reference in New Issue
Block a user
Delete Branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Updating original report:
I had reset my "live settings" configuration to default after upgrading to 1.4, because my old (default) configuration's setting for BK_PARTS_DEFAULT_ORDER conflicted with the new update (see closed issue #148). As it turns out, many of the fields are just cleared out, instead of having defaults applied when resetting to defaults. This made any data retrieval from rebrickable where images were unavailable, updating themes, retired sets, and even accessing instructions not work.
I was able to restore most of broken behavior, including set refresh and adding of sets with missing images by manually copying the default settings from the setting descriptions and saving. A few fields don't seem to properly be reassigned by doing that, including BK_INSTRUCTIONS_ALLOWED_EXTENSIONS , BK_BADGE_ORDER_GRID, and BK_BADGE_ORDER_DETAIL.
BK_INSTRUCTIONS_ALLOWED_EXTENSIONS now allows me to open instructions, instead of treating them as "Rejected files", but the allowed formats is wrong:
Allowed file formats for instructions are the following: [, ", ., p, d, f, ", ].I am unable to get the badges to show up in the grid or detail views.
I have not tried resetting any of the static settings to defaults.
The original report / symptoms follow:
On version 1.4, I'm finding that refreshing set data or adding a set encounters an error when a part (of a minifigure?) or a minifigure doesn't have an image on rebrickable. This actually fully blocks the addition of sets that have missing images.
I was able to reproduce with the following sets:
10391-1, 60446-1, and 71497-1.
In the case of 10391-1, after failing to refresh the set data, I tried both adding the set as a duplicate, and also removing my extant copy via the delete functionality, and in both cases, the set was not added to my collection. I only tried refreshing and adding the other two as duplicates, since I was unable to re-add 10391-1 after removing it.
Error: Error while importing minifigure fig-015523 from 10391-1: Invalid URL '': No scheme supplied. Perhaps you meant https://?Error: Error while importing minifigure fig-015738 from 60446-1: Invalid URL '': No scheme supplied. Perhaps you meant https://?Error: Error while importing part 973c46h01pr0005 from Minifigure fig-015813: Invalid URL '': No scheme supplied. Perhaps you meant https://?These sets were already in my collection, but they encounter the same error when I either add a new copy or try to refresh set data. In contrast, sets that previously were missing images prior to the 1.4.0 upgrade in my collection, but have since gotten images uploaded on rebrickable update just fine (tested with 11203-1 and 40755-1, which properly updated the missing images)
Every field in the URL Patterns & Links section is blank, and to be extra safe, I reset everything to defaults and hit "save all changes", even restarting my BrickTracker container.
Error when adding / refreshing set data with missing images on rebrickable.to "Reset to defaults" for configuration clears out all settings instead of applying defaults.Thanks for the report and for tracking down the workaround yourself. That really helped narrow things down.
Three separate fixes are fixed in 1.4.1:
BK_INSTRUCTIONS_ALLOWED_EXTENSIONSwere being stored as plain strings instead of lists after saving via theadmin panel. Fixed the type casting so they round-trip correctly
The fixes are available now in the
pre-1.4.1Docker tag if you want to test. Will be pushed to1.4.1andlatestonce a couple more things are sorted.Confirmed working. TY!