@gregoo Thanks for pushing me to read the code again. I pushed changes to the instructions branch.
Notes
- Added link in
/template/set/card.htmlto the download page. - Updated…
d2fa72dc63
Merge pull request 'Database migration tool, deduplication of sets data, customizable checkboxes' (#44) from gregoo/BrickTracker:master into master
Thank you 😃 I moved some code around, but there's still a few things i need sorted. I'll work on it tonight and see how it goes.
d2fa72dc63
Merge pull request 'Database migration tool, deduplication of sets data, customizable checkboxes' (#44) from gregoo/BrickTracker:master into master
Sounds good! I'll go ahead and merge.
Sorry you feel this way. I'm really trying to learn and I wouldn't call my import code production ready. I had plans to go through it this weekend. Especially the things you mention (bs4) and…
I'm thinking this would be good for a 1.1.0 and then instructions download could be 1.2.0, as I would like to improve it a bit.
Then we also don't get a monster release with too many changes…
Would be great if you could take a look.
What's implemented is:
- A button on the set page like the upload button.
- A button on the
/instructionspage - Prefill set-number when coming…
I did a couple of tests with ~8000 rows and loading time is ~7s. Which is pretty acceptable. So i think we are good there.
The downloader works and it is possible to select which instructions you want downloaded. They are downloaded to the correct folder and then the rename/delete works as with manually uploaded…