FrederikBaerentsen/BrickTracker
5
10
Fork 6
Code Issues 12 Pull Requests 1 Actions Packages Projects 1 Releases 4 Wiki Activity

Can't search the part "Brick" with links on #49

New Issue
Closed
opened 2025-01-24 12:39:36 +01:00 by gregoo · 3 comments
gregoo commented 2025-01-24 12:39:36 +01:00
Collaborator
Copy Link

The search component searches everything within the cell. If the Rebrickable/Bricklink link is here, it will pick up the url as a valid result.

With (useless):
image

Without (expected):
image

The search component searches everything within the cell. If the Rebrickable/Bricklink link is here, it will pick up the url as a valid result. With (useless): ![image](/attachments/3c4d056b-2dd9-455e-a03f-62ef6e6f162c) Without (expected): ![image](/attachments/74d0ac75-95cf-46e4-80a2-ca107039d030)
image.png
167 KiB
image.png
136 KiB
gregoo commented 2025-01-24 14:54:40 +01:00
Author
Collaborator
Copy Link

A custom searchMethod seem to fix the issue

image
image
image

A custom `searchMethod` seem to fix the issue ![image](/attachments/bf01bc30-675e-4d7d-aa15-4c2e3a0e8fbc) ![image](/attachments/33e03174-0e3a-4cc6-89d8-b0138646115f) ![image](/attachments/0d21ce04-70a3-44e4-a8ed-537da0085006)
image.png
52 KiB
image.png
152 KiB
image.png
174 KiB
gregoo commented 2025-01-24 16:01:50 +01:00
Author
Collaborator
Copy Link

Fixed in 623b205733

Fixed in 623b205733d786f32fd77999524364a646d58e2d
FrederikBaerentsen commented 2025-01-24 23:50:13 +01:00
Owner
Copy Link

Closed. Working in v1.1.0

Closed. Working in v1.1.0
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
Compat/Breaking
Breaking change that won't be backward compatible
Kind/Bug
Something is not working
Kind/Documentation
Documentation changes
Kind/Enhancement
Improve existing functionality
Kind/Feature
New functionality
Kind/Security
This is security issue
Kind/Testing
Issue or pull request related to testing
Priority
Critical
The priority is critical
Priority
High
The priority is high
Priority
Low
The priority is low
Priority
Medium
The priority is medium
Reviewed
Confirmed
Issue has been confirmed
Reviewed
Duplicate
This issue or pull request already exists
Reviewed
Invalid
Invalid issue
Reviewed
Won't Fix
This issue won't be fixed
Status
Abandoned
Somebody has started to work on this but abandoned work
Status
Blocked
Something is blocking this issue or pull request
Status
Need More Info
Feedback is required to reproduce issue or to continue work
Unraid
Unsupported/Can't help
No Label
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
No Assignees
2 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: FrederikBaerentsen/BrickTracker#49
No description provided.
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?