Instructions downloader #54

Merged

FrederikBaerentsen merged 19 commits from instructions into master 2025-01-26 19:17:42 +01:00

Conversation 0 Commits 19 Files Changed 18 +723 -253

gregoo commented 2025-01-26 09:49:58 +01:00

Collaborator

Copy Link

This first version can be shipped imho. Looks nice and is very useful 🙂

This first version can be shipped imho. Looks nice and is very useful 🙂

gregoo added 19 commits 2025-01-26 09:49:58 +01:00

Added instructions downloader from Rebrickable. 053bf75e05

Added bs4 to requirements.txt 9aa5bd43ec

Moved from code around 4a785df532

Moved code from views to instructions.py 6320629b07

Merge remote-tracking branch 'origin/master' into instructions 6abf4a314f

Moved code and added env variables 52f73d5bf9

Move parse_number out of RebrickableSet as it imports way too much for such a simple function 6d3285dbc9

Global cleanup of the code, implementing all the comments for the issue ed44fb9bab

Fix the default value fd38e0a150

Merge pull request 'Implementation of the comments from #45' (#51) from gregoo/BrickTracker:instructions into instructions ... f48ae99179

Reviewed-on: #51

Split the JS socket with a generic part and one dedicated to load Rebrickable sets 9113d539f0

Dowloads instructions through a socket c4a1a17cfd

Increase the socket status polling interval to 1s 9b5774555f

Remove unused 'ADD_SET' socket message cf9e716d1c

Trim the url in the progress message to make it more legible 48ad7b5f02

Clear the progress message when clear() acebf6efd6

Fix a bug when normalizing total in progress() 19750d1365

Clear the socket when clicking the button 2db0c1c2eb

Merge pull request 'Downloading the instructions through the socket' (#53) from gregoo/BrickTracker:instructions into instructions ... c7b90414d3

Reviewed-on: #53

FrederikBaerentsen merged commit a9bf5e03f8 into master 2025-01-26 19:17:42 +01:00

FrederikBaerentsen referenced this issue from a commit 2025-01-26 19:17:43 +01:00

Merge pull request 'Instructions downloader' (#54) from instructions into master

Sign in to join this conversation.

Reviewers

No Reviewers

Labels

Clear labels

Compat/Breaking

Breaking change that won't be backward compatible

Kind/Bug

Something is not working

Kind/Documentation

Documentation changes

Kind/Enhancement

Improve existing functionality

Kind/Feature

New functionality

Kind/Security

This is security issue

Kind/Testing

Issue or pull request related to testing

Priority

Critical

The priority is critical

Priority

High

The priority is high

Priority

Low

The priority is low

Priority

Medium

The priority is medium

Reviewed

Confirmed

Issue has been confirmed

Reviewed

Duplicate

This issue or pull request already exists

Reviewed

Invalid

Invalid issue

Reviewed

Won't Fix

This issue won't be fixed

Status

Abandoned

Somebody has started to work on this but abandoned work

Status

Blocked

Something is blocking this issue or pull request

Status

Need More Info

Feedback is required to reproduce issue or to continue work

Unraid

Unsupported/Can't help

No Label

Milestone

No items

No Milestone

Projects

Clear projects

No project

Assignees

Clear assignees

No Assignees

1 Participants

Notifications

Subscribe

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: FrederikBaerentsen/BrickTracker#54

No description provided.