FrederikBaerentsen/BrickTracker
7
17
Fork 11
Code Issues 17 Pull Requests Actions Packages Projects 1 Releases 6 Wiki Activity

Fixed the rebrickable scraping to deal with changes #81

Merged
FrederikBaerentsen merged 2 commits from hiddenside/BrickTracker:fix-instructions-download into master 2025-08-08 19:47:15 +02:00
Conversation 7 Commits 2 Files Changed 2 +94 -97
hiddenside commented 2025-08-01 07:32:31 +02:00
Contributor
Copy Link

Created a common naming schema for the instructions when downloaded
setnumber-set-name-rebrickable-name
so set 3816-1 Glove World would end up
3816-1-Glove-World-BI-3004-32-3816-V-29-39
If there is ever a duplicate name it appends _1+++

Created a common naming schema for the instructions when downloaded setnumber-set-name-rebrickable-name so set 3816-1 Glove World would end up 3816-1-Glove-World-BI-3004-32-3816-V-29-39 If there is ever a duplicate name it appends _1+++
hiddenside added 1 commit 2025-08-01 07:32:31 +02:00
Fixed the rebrickable scraping to deal with changes 48aaeddb85 
Created a common naming schema for the instructions when downloaded
	setnumber-set-name-rebrickable-name
so set 3816-1 Glove World would end up
	3816-1-Glove-World-BI-3004-32-3816-V-29-39
If there is ever a duplicate name it appends _1+++
hiddenside commented 2025-08-01 07:40:22 +02:00
Author
Contributor
Copy Link

Using this in my .env file
REBRICKABLE_LINK_INSTRUCTIONS_PATTERN="https://rebrickable.com/instructions/{path}/"

Using this in my .env file `REBRICKABLE_LINK_INSTRUCTIONS_PATTERN="https://rebrickable.com/instructions/{path}/"`
hiddenside requested review from FrederikBaerentsen 2025-08-02 08:46:36 +02:00
FrederikBaerentsen commented 2025-08-02 13:19:58 +02:00
Owner
Copy Link

Just tested the code. It works great. Only issue i found is the progress bar for the download. Let me know when you are satisfied and I'll merge it 👍

Just tested the code. It works great. Only issue i found is the progress bar for the download. Let me know when you are satisfied and I'll merge it 👍
hiddenside commented 2025-08-02 18:35:20 +02:00
Author
Contributor
Copy Link

Thanks @FrederikBaerentsen I will check out the progress bar today and update and rebase the PR and remove the WIP.

Thanks @FrederikBaerentsen I will check out the progress bar today and update and rebase the PR and remove the WIP.
hiddenside force-pushed fix-instructions-download from 48aaeddb85 to 79f348178c 2025-08-02 21:17:34 +02:00 Compare
hiddenside changed title from WIP: Fixed the rebrickable scraping to deal with changes to Fixed the rebrickable scraping to deal with changes 2025-08-02 21:18:44 +02:00
hiddenside commented 2025-08-02 21:19:31 +02:00
Author
Contributor
Copy Link

@FrederikBaerentsen please test again I believe I resolved the progress bar how it's working across the app. Thanks!

@FrederikBaerentsen please test again I believe I resolved the progress bar how it's working across the app. Thanks!
hiddenside removed review request for FrederikBaerentsen 2025-08-04 08:09:30 +02:00
hiddenside requested review from FrederikBaerentsen 2025-08-04 08:09:36 +02:00
hiddenside commented 2025-08-08 17:30:00 +02:00
Author
Contributor
Copy Link

@FrederikBaerentsen anything else needed to get this merged? I have other PR's to open but just wanted to make sure this would get merged before pushing more. Thanks!

@FrederikBaerentsen anything else needed to get this merged? I have other PR's to open but just wanted to make sure this would get merged before pushing more. Thanks!
FrederikBaerentsen commented 2025-08-08 17:52:12 +02:00
Owner
Copy Link

@hiddenside Been busy with work, but i'll merge it tonight! Just need to test the docker container again.

@hiddenside Been busy with work, but i'll merge it tonight! Just need to test the docker container again.
FrederikBaerentsen merged commit 7bfbbbf298 into master 2025-08-08 19:47:15 +02:00
FrederikBaerentsen commented 2025-08-08 19:56:40 +02:00
Owner
Copy Link

The docker image has been pushed to :latest.

The docker image has been pushed to `:latest`.
Sign in to join this conversation.
Reviewers
No Reviewers
FrederikBaerentsen
Labels
Clear labels
Compat/Breaking
Breaking change that won't be backward compatible
 Kind/Bug
Something is not working
 Kind/Documentation
Documentation changes
 Kind/Enhancement
Improve existing functionality
 Kind/Feature
New functionality
 Kind/Security
This is security issue
 Kind/Testing
Issue or pull request related to testing
 Out of Scope
Request is out of scope
Priority
Critical
The priority is critical
Priority
High
The priority is high
Priority
Low
The priority is low
Priority
Medium
The priority is medium
Reviewed
Confirmed
Issue has been confirmed
Reviewed
Duplicate
This issue or pull request already exists
Reviewed
Invalid
Invalid issue
Reviewed
Won't Fix
This issue won't be fixed
Status
Abandoned
Somebody has started to work on this but abandoned work
Status
Blocked
Something is blocking this issue or pull request
Status
Need More Info
Feedback is required to reproduce issue or to continue work
Unraid
Unsupported/Can't help
No Label
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
gregoo FrederikBaerentsen
No Assignees
2 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: FrederikBaerentsen/BrickTracker#81
Delete Branch "hiddenside/BrickTracker:fix-instructions-download"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?