FrederikBaerentsen/BrickTracker
8
20
Fork 12
Code Issues 10 Pull Requests Actions Packages Projects 1 Releases 9 Wiki Activity

[Feature] Add retirement dates for sets already retired #37

New Issue
Open
opened 2025-01-06 23:27:46 +01:00 by jonaskp · 6 comments
jonaskp commented 2025-01-06 23:27:46 +01:00
Copy Link
Copy Source

Current implementation of retirement date pulls data from a source that tracks upcoming retirements.
This means that when adding a set to wishlist which is already retired, retirement date will not be picked up, and field will be empty.

Feature request is to find a data source that has retirement dates for already retired sets, and add this date to the wishlist.
Brickset and Rebrickable seems to have "to"/"exit"-dates for retired sets.

Additional: Colorcoding the retirement dates: ie. Yellow for upcoming retirements, red for already retired sets.

Example set already retired: Set 10185:
https://brickset.com/sets/10185-1/Green-Grocer
https://rebrickable.com/sets/10185-1/green-grocer/

Current implementation of retirement date pulls data from a source that tracks upcoming retirements. This means that when adding a set to wishlist which is already retired, retirement date will not be picked up, and field will be empty. Feature request is to find a data source that has retirement dates for already retired sets, and add this date to the wishlist. Brickset and Rebrickable seems to have "to"/"exit"-dates for retired sets. Additional: Colorcoding the retirement dates: ie. Yellow for upcoming retirements, red for already retired sets. Example set already retired: Set 10185: https://brickset.com/sets/10185-1/Green-Grocer https://rebrickable.com/sets/10185-1/green-grocer/
👍 1
FrederikBaerentsen commented 2025-01-19 08:22:56 +01:00
Owner
Copy Link
Copy Source

Retirement date is unfortunately not part of the rebrickable api, which is why it is implemented differently.

Retirement date is unfortunately not part of the rebrickable api, which is why it is implemented differently.
FrederikBaerentsen added the Kind/Enhancement label 2025-01-19 08:23:02 +01:00
jonaskp commented 2025-01-19 08:30:56 +01:00
Author
Copy Link
Copy Source

Ahh, Thought it might only be the “future retirement” that wasn’t there, from how I read the initial discussion on this feature.

So it would need to implement another source (for instance Brickset, which I dont know about, so not even sure if it has api or it would work).

As a possible workaround, maybe make it so retirement date, once it has been pickee up by current implementation, is not deleted from BrickTracker again, once it is removed from the spreadsheet.

That Way, it would atleast Track previously reirement of sets you added before they were retired.

Not sure if it already Works this Way now.

Ahh, Thought it might only be the “future retirement” that wasn’t there, from how I read the initial discussion on this feature. So it would need to implement another source (for instance Brickset, which I dont know about, so not even sure if it has api or it would work). As a possible workaround, maybe make it so retirement date, once it has been pickee up by current implementation, is not deleted from BrickTracker again, once it is removed from the spreadsheet. That Way, it would atleast Track previously reirement of sets you added before they were retired. Not sure if it already Works this Way now.
FrederikBaerentsen commented 2025-01-19 10:36:34 +01:00
Owner
Copy Link
Copy Source

Rebrickable gives this info in their API:

{
  "set_num": "10185-1",
  "name": "Green Grocer",
  "year": 2008,
  "theme_id": 155,
  "num_parts": 2358,
  "set_img_url": "https://cdn.rebrickable.com/media/sets/10185-1/70981.jpg",
  "set_url": "https://rebrickable.com/sets/10185-1/green-grocer/",
  "last_modified_dt": "2016-04-23T11:53:18.502825Z"
}

Which unfortunately isn't a lot compared to what's available on their site.

It looks like Brickset does offer a launch and retirement date in their API, but getting an API key is a manual application and not automatic, which makes it harder.

Saving previous dates could work. I will keep the issue open and add it as an idea for future improvements.

Rebrickable gives this info in their API: ````json { "set_num": "10185-1", "name": "Green Grocer", "year": 2008, "theme_id": 155, "num_parts": 2358, "set_img_url": "https://cdn.rebrickable.com/media/sets/10185-1/70981.jpg", "set_url": "https://rebrickable.com/sets/10185-1/green-grocer/", "last_modified_dt": "2016-04-23T11:53:18.502825Z" } ```` Which unfortunately isn't a lot compared to what's available on their site. It looks like Brickset does offer a launch and retirement date in their API, but getting an API key is a manual application and not automatic, which makes it harder. Saving previous dates could work. I will keep the issue open and add it as an idea for future improvements.
👍 1
FrederikBaerentsen added this to the General Improvements project 2025-01-19 10:36:41 +01:00
FrederikBaerentsen changed title from Add retirement dates for sets already retired to [Feature] Add retirement dates for sets already retired 2025-09-22 08:52:55 +02:00
FrederikBaerentsen added the
Priority
Low
 label 2026-01-01 17:03:03 +01:00
FrederikBaerentsen commented 2026-01-04 17:42:21 +01:00
Owner
Copy Link
Copy Source

@jonaskp

I might have found a solution to this problem. If I'm able to source release/retirement dates (mix of Bricklink/Rebrickable/Brickset/Peeron/LEGO.com/brickipedia.fandom info), I'm thinking of adding a second container that runs a very simple FastAPI container which can query a set number (eg. http://localhost:8000/21005) and it then returns a json object with data needed.

This way I can update the secondary image more often with new data. I'm also thinking of adding data like official LEGO description, tags, age rating, MSRP etc to this data. But I'm trying not to bundle it with BrickTracker to avoid constant update of the container image.

BrickTracker could check if this container is available and automatically use this info on /wishes and set-details could also use this info if needed.

@jonaskp I might have found a solution to this problem. If I'm able to source release/retirement dates (mix of Bricklink/Rebrickable/Brickset/Peeron/LEGO.com/brickipedia.fandom info), I'm thinking of adding a second container that runs a very simple FastAPI container which can query a set number (eg. http://localhost:8000/21005) and it then returns a json object with data needed. This way I can update the secondary image more often with new data. I'm also thinking of adding data like official LEGO description, tags, age rating, MSRP etc to this data. But I'm trying not to bundle it with BrickTracker to avoid constant update of the container image. BrickTracker could check if this container is available and automatically use this info on `/wishes` and set-details could also use this info if needed.
FrederikBaerentsen added this to the Future versions milestone 2026-01-04 17:43:04 +01:00
fatherfork commented 2026-01-19 18:04:01 +01:00
Contributor
Copy Link
Copy Source

@FrederikBaerentsen I created an account to request an option for automatic release MSRP filling for the "Price" field because I'd rather have that than nothing, maintaining the ability to edit for difference when purchase price is actually different from MSRP. Seems like this may be "easily" (I don't think any feature is easy, I'm not trying to imply I'm one of those people) added to this particular feature if you're planning to have the MSRP available anyway. Would you like me to make a new feature request or just leave it tacked on to this one?

@FrederikBaerentsen I created an account to request an option for automatic release MSRP filling for the "Price" field because I'd rather have that than nothing, maintaining the ability to edit for difference when purchase price is actually different from MSRP. Seems like this may be "easily" (I don't think any feature is easy, I'm not trying to imply I'm one of those people) added to this particular feature if you're planning to have the MSRP available anyway. Would you like me to make a new feature request or just leave it tacked on to this one?
FrederikBaerentsen commented 2026-01-19 18:22:44 +01:00
Owner
Copy Link
Copy Source

@fatherfork Let's keep it in this feature request, as it's similar.
As mentioned before, the issue is where to source the data from. Rebrickable doesn't include it in their API, so we need it elsewhere from. It is a hassle for everyone to have their own API key for Brickset.

After i get done with #68 and #69, I'll look at this one.

@fatherfork Let's keep it in this feature request, as it's similar. As mentioned before, the issue is where to source the data from. Rebrickable doesn't include it in their API, so we need it elsewhere from. It is a hassle for everyone to have their own API key for Brickset. After i get done with #68 and #69, I'll look at this one.
👍 1
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
Compat/Breaking
Breaking change that won't be backward compatible
 Kind/Bug
Something is not working
 Kind/Documentation
Documentation changes
 Kind/Enhancement
Improve existing functionality
 Kind/Feature
New functionality
 Kind/Security
This is security issue
 Kind/Testing
Issue or pull request related to testing
 Out of Scope
Request is out of scope
Priority
Critical
The priority is critical
Priority
High
The priority is high
Priority
Low
The priority is low
Priority
Medium
The priority is medium
Reviewed
Confirmed
Issue has been confirmed
Reviewed
Duplicate
This issue or pull request already exists
Reviewed
Invalid
Invalid issue
Reviewed
Won't Fix
This issue won't be fixed
Status
Abandoned
Somebody has started to work on this but abandoned work
Status
Blocked
Something is blocking this issue or pull request
Status
Need More Info
Feedback is required to reproduce issue or to continue work
Unraid
Unsupported/Can't help
No Label Kind/Enhancement
Priority
Low
Milestone
No items
No Milestone Future versions
Projects
Clear projects
No project General Improvements
Assignees
Clear assignees
FrederikBaerentsen
No Assignees
3 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: FrederikBaerentsen/BrickTracker#37
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?