Add retirement dates for sets already retired #37
Labels
No Label
Compat/Breaking
Kind/Bug
Kind/Documentation
Kind/Enhancement
Kind/Feature
Kind/Security
Kind/Testing
Priority
Critical
Priority
High
Priority
Low
Priority
Medium
Reviewed
Confirmed
Reviewed
Duplicate
Reviewed
Invalid
Reviewed
Won't Fix
Status
Abandoned
Status
Blocked
Status
Need More Info
Unraid
No Milestone
No project
No Assignees
2 Participants
Notifications
Due Date
No due date set.
Dependencies
No dependencies set.
Reference: FrederikBaerentsen/BrickTracker#37
Loading…
Reference in New Issue
Block a user
No description provided.
Delete Branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Current implementation of retirement date pulls data from a source that tracks upcoming retirements.
This means that when adding a set to wishlist which is already retired, retirement date will not be picked up, and field will be empty.
Feature request is to find a data source that has retirement dates for already retired sets, and add this date to the wishlist.
Brickset and Rebrickable seems to have "to"/"exit"-dates for retired sets.
Additional: Colorcoding the retirement dates: ie. Yellow for upcoming retirements, red for already retired sets.
Example set already retired: Set 10185:
https://brickset.com/sets/10185-1/Green-Grocer
https://rebrickable.com/sets/10185-1/green-grocer/
Retirement date is unfortunately not part of the rebrickable api, which is why it is implemented differently.
Ahh, Thought it might only be the “future retirement” that wasn’t there, from how I read the initial discussion on this feature.
So it would need to implement another source (for instance Brickset, which I dont know about, so not even sure if it has api or it would work).
As a possible workaround, maybe make it so retirement date, once it has been pickee up by current implementation, is not deleted from BrickTracker again, once it is removed from the spreadsheet.
That Way, it would atleast Track previously reirement of sets you added before they were retired.
Not sure if it already Works this Way now.
Rebrickable gives this info in their API:
Which unfortunately isn't a lot compared to what's available on their site.
It looks like Brickset does offer a launch and retirement date in their API, but getting an API key is a manual application and not automatic, which makes it harder.
Saving previous dates could work. I will keep the issue open and add it as an idea for future improvements.