[Feature Request] Downloading Instructions Enhancements; Set Refresh Enhancements #127
Reference in New Issue
Block a user
Delete Branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
I am really loving the updates, especially dark mode - so thanks for doing that and maintaining this excellent little app.
I would like to propose some enhancements to the instructions downloading:
For Set Refresh Enhancement I'd like to see the ability to batch refresh many at a time.
Maybe a scheduler of some sort to execute cronjobs? Just brainstorming. Thank you again for this excellent app - I hope you have a great Christmas and a Merry New Year!
Thank you so much for the kind words and feature suggestions! I'm really glad you're enjoying the app and that dark mode is working well for you.
Both automatic instructions download and batch refresh are already things I've been looking at.
Batch Refresh: This one was straightforward and made a lot of sense, so I've already added it to the next update! You'll now see a "Bulk Refresh" button on the Admin -> Sets needing refresh page when you have multiple sets that need updating.
It follows the same pattern as bulk add; just paste in your comma-separated set numbers (or use the pre-populated list) and hit refresh. Can be tested on docker tag
pre-1.4. Will be released with version 1.4. Changelog can be found here.Instructions Download Enhancements: The instructions features are more complex than they initially appear. Most sets have multiple instruction file variants (US version, EU version, different languages, etc.), and users currently select which specific files they want to download. This means that simple "auto-download" checkboxes would need either:
The challenge is that most instructions don't follow a clear pattern. Many newer sets do use patterns like V39 for US, V29 for EU, and standard X/Y for instruction numbering (e.g., "1 of 2"). However, this consistency breaks down with older sets. For example, set 21042-1 provides:
Here it's very difficult to auto-select a manual. We could prioritize V29 or V39, but what about set 8258-1 where we get:
I'm still brainstorming the best approach to handle this, as it's definitely a feature I want to implement. Regarding cronjobs; what specific tasks did you have in mind? Set refreshes would likely be very infrequent going forward and would only be necessary if the inventory data on Rebrickable changes.
Wishing you a wonderful Christmas as well and a Happy New Year! 🎄
Thanks so much for adding the bulk refresh feature so quickly - that'll come in handy - I'll test it out soon.
For the instructions I think making any kind of automated downloading optional, and then defaulting to whatever would match the timezone locale - if specified - or using an optional variable. But for older sets if there isn't any kind of matching possible on a particular set, specifically on older sets - perhaps present the user with a list to select which ones to import? Maybe an option variable for instructions that could include
-Always download all matches
-Download locale matches only
-Present a list when no locale match is possible
-Present a list always
-..... More I'm not thinking of?
I was thinking that cron could be used for some of these tasks to run in the background - like downloading instructions or set refreshes, but if they aren't going to be as needed going forward then it doesn't really make sense to implement.
Thanks again - will update to the 1.4 preview in a bit here and post back any feedback :-)
The bulk refresh worked a treat in terms of process - thank you. I went from 22 sets needing a refresh to 18. I'm wondering why 18 are still showing as needing a refresh, though.
On the sets needing refresh page it lists the issue count - is there a way to see which parts are detected as having issues? For example, 71369-1 is showing as having 9 Bricklink issues, 3 empty URLs, 3 empty transparent, 3 empty RGB.
Could you provide a copy of your database? I don't see a specific issue with 71369-1.
I have explained why some sets doesn't disappears from Refresh list in #119.
db attached.
The refresh functionality I just fixed in different issue (
5418aca8f0), it ensures that when you refresh a set, the parts data syncs properly with Rebrickable while preserving your tracking data (checked/missing/damaged).I updated
pre-1.4and it should now work. I tested it on your DB.PERFECT! Updated, and refresh works exactly as expected. Well Done!