Sounds good! I'll go ahead and merge.
Sorry you feel this way. I'm really trying to learn and I wouldn't call my import code production ready. I had plans to go through it this weekend. Especially the things you mention (bs4) and…
I'm thinking this would be good for a 1.1.0 and then instructions download could be 1.2.0, as I would like to improve it a bit.
Then we also don't get a monster release with too many changes…
Would be great if you could take a look.
What's implemented is:
- A button on the set page like the upload button.
- A button on the
/instructions
page - Prefill set-number when coming…
I did a couple of tests with ~8000 rows and loading time is ~7s. Which is pretty acceptable. So i think we are good there.
The downloader works and it is possible to select which instructions you want downloaded. They are downloaded to the correct folder and then the rename/delete works as with manually uploaded…
Good idea. I was just thinking about the labels the other day and how they probably needed to be customized.
I must be blind. I see the search bar now. That’s fair enough. You are right, the parts page probably isn’t used that much (there’s also a long loading time for the page). I’ll close the…
I created an instructions branch and moved those two commits over there. Hopefully that should fix the issues. I'll work on that branch until i have a finished version.
Okay, i see. I'm not used to working with git and other people. I'll roll back and create a new branch for that code.
@gregoo What's your thought on a search far or filter on the parts
page and the parts section of the sets
page?