FrederikBaerentsen/ComicOPDS
1
2
Fork 1
Code Issues 6 Pull Requests Packages Projects Releases 1 Wiki Activity

Make cbz file paths into OpenAPI path arguments #26

Merged
FrederikBaerentsen merged 1 commits from antifuchs/ComicOPDS:move-path-to-path into develop 2026-01-13 13:04:24 +01:00
Conversation 2 Commits 1 Files Changed 2
+29 -27
antifuchs commented 2025-12-15 21:35:31 +01:00
Contributor
Copy Link
Copy Source

FastAPI, in Query arguments, interprets characters like +, ; and ' in special ways (see https://github.com/fastapi/fastapi/issues/720), which causes issues with the requests that some clients such as Panels send: Receiving these bare characters results in request errors.

So in order to prevent that special handling, move the path argument into the URL path: That eliminates the special-handling of those characters, resulting in far more requests from affected clients succeeding.

This fixes #25

FastAPI, in Query arguments, interprets characters like `+`, `;` and `'` in special ways (see https://github.com/fastapi/fastapi/issues/720), which causes issues with the requests that some clients such as Panels send: Receiving these bare characters results in request errors. So in order to prevent that special handling, move the `path` argument into the URL path: That eliminates the special-handling of those characters, resulting in far more requests from affected clients succeeding. This fixes #25
antifuchs commented 2025-12-15 21:36:18 +01:00
Author
Contributor
Copy Link
Copy Source

(My editor tried to automatically pep8-format the main.py file, which I have attempted to undo manually; I hope no annoying reformats slipped through)

(My editor tried to automatically pep8-format the main.py file, which I have attempted to undo manually; I hope no annoying reformats slipped through)
antifuchs changed title from Make cbz file paths into path OpenAPI arguments to Make cbz file paths into OpenAPI path arguments 2025-12-15 21:37:00 +01:00
FrederikBaerentsen commented 2025-12-18 04:25:13 +01:00
Owner
Copy Link
Copy Source

Thanks for the PR, I'll read through it and test it out! 👍

Thanks for the PR, I'll read through it and test it out! 👍
❤️ 1
FrederikBaerentsen changed target branch from master to develop 2026-01-13 13:04:12 +01:00
FrederikBaerentsen added 1 commit 2026-01-13 13:04:12 +01:00
Make cbz file paths into path OpenAPI arguments 5129bdbb3b 
FastAPI, in Query arguments, interprets characters like `+`, `;` and `'` in special ways (see https://github.com/fastapi/fastapi/issues/720), which causes issues with the requests that some clients such as Panels send: Receiving these bare characters results in request errors.

So in order to prevent that special handling, move the `path` argument into the URL path: That eliminates the special-handling of those characters, resulting in far more requests from affected clients succeeding.
FrederikBaerentsen merged commit a30b461a52 into develop 2026-01-13 13:04:24 +01:00
Sign in to join this conversation.
Reviewers
No Reviewers
Labels
Clear labels
bug
Something is not working
 duplicate
This issue or pull request already exists
 enhancement
New feature
 help wanted
Need some help
 invalid
Something is wrong
 question
More information is needed
 wontfix
This won't be fixed
No Label
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
FrederikBaerentsen
No Assignees
2 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: FrederikBaerentsen/ComicOPDS#26
Delete Branch "antifuchs/ComicOPDS:move-path-to-path"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?